GH-116380: Move pathlib-specific code from glob to pathlib._abc.#120011
+52 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…abc`. In `glob._Globber`, move pathlib-specific methods to `pathlib._abc.Globber` and replace them with abstract methods. Rename `glob._Globber` to `glob._GlobberBase`, and `glob._StringGlobber` to `glob._Globber`. As a result, the `glob` module is no longer befouled by code that can only ever apply to pathlib. No change of behaviour.
barneygale added needs backport to 3.13 
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @barneygale, I could not cleanly backport this to |
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…abc`. (python#120011) In `glob._Globber`, move pathlib-specific methods to `pathlib._abc.PathGlobber` and replace them with abstract methods. Rename `glob._Globber` to `glob._GlobberBase`. As a result, the `glob` module is no longer befouled by code that can only ever apply to pathlib. No change of behaviour.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…abc`. (python#120011) In `glob._Globber`, move pathlib-specific methods to `pathlib._abc.PathGlobber` and replace them with abstract methods. Rename `glob._Globber` to `glob._GlobberBase`. As a result, the `glob` module is no longer befouled by code that can only ever apply to pathlib. No change of behaviour.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
glob._Globber, move pathlib-specific methods topathlib._abc.Globberand replace them with abstract methods. Renameglob._Globbertoglob._GlobberBase, andglob._StringGlobbertoglob._Globber. As a result, theglobmodule is no longer befouled by code that can only ever apply to pathlib.No change of behaviour.
glob.glob()by reducing number of system calls made #116380