Skip to content

gh-120026: deprecate (soft) Py_HUGE_VAL macro#120027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 8 commits into from
Nov 1, 2024
Merged

gh-120026: deprecate (soft) Py_HUGE_VAL macro #120027

vstinner merged 8 commits into from
Nov 1, 2024

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented Jun 4, 2024•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jun 4, 2024
Closed
@skirpichev
Copy link
MemberAuthor

skirpichev commented Jun 4, 2024

As mentioned here I'm not sure that Py_NAN/INFINITY now are really required.

AA-Turner
AA-Turner reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording suggestions.

A

@skirpichev@AA-Turner
Apply suggestions from code review
9abcb58
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@skirpichev
Copy link
MemberAuthor

skirpichev commented Oct 31, 2024

CC @vstinner

vstinner
vstinner reviewed Nov 1, 2024
View reviewed changes
vstinner
vstinner approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner enabled auto-merge (squash) November 1, 2024 16:27
@vstinnervstinner merged commit 8477951 into python:mainNov 1, 2024
@skirpichevskirpichev deleted the sd-Py_HUGE_VAL branch November 2, 2024 03:13
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@skirpichev@AA-Turner@picnixz
pythongh-120026: soft deprecate Py_HUGE_VAL macro (python#120027)
ac54828
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@skirpichev@AA-Turner@ebonnal
pythongh-120026: soft deprecate Py_HUGE_VAL macro (python#120027)
e19acbd
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev@vstinner@AA-Turner