gh-120298: Fix use-after-free in list_richcompare_impl#120303
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
What bisect or deque do with this?
What tests were added for the similar case above?
Member
serhiy-storchaka commented Jun 10, 2024
MemberAuthor
sobolevn commented Jun 10, 2024
Yes, @serhiy-storchaka, you are correct. I simplified the reproduction to: classevil(object): def__lt__(self, other): other.clear() returnNotImplementeda= [ [ evil()]] a[0] <a# crash without this patchI've updated tests to store this test near |
serhiy-storchaka approved these changes Jun 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
sobolevn added needs backport to 3.12 
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2024
…nGH-120303) (cherry picked from commit 141baba) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2024
…nGH-120303) (cherry picked from commit 141baba) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-120339 is a backport of this pull request to the 3.12 branch. |
GH-120340 is a backport of this pull request to the 3.13 branch. |
sobolevn added a commit that referenced this pull request Jun 11, 2024
sobolevn added a commit that referenced this pull request Jun 11, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
…n#120303) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…n#120303) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…n#120303) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code does the same thing as the code above it:
cpython/Objects/listobject.c
Lines 3360 to 3364 in 0ae8579
And looks like it gets the job done. I've added tests for these two corner cases.