Skip to content

Fix typos in documentation#120338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sobolevn merged 1 commit into from
Jun 12, 2024
Merged

Fix typos in documentation #120338

sobolevn merged 1 commit into from
Jun 12, 2024

Conversation

@xyb
Copy link
Contributor

@xybxyb commented Jun 11, 2024

No description provided.

@xybxyb requested a review from terryjreedy as a code ownerJune 11, 2024 06:07
@serhiy-storchakaserhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 11, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sobolevn
sobolevn approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sobolevn
sobolevn requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like help.html file is generated from:

Help => IDLE Help: Display help.html with proper formatting. Doc/library/idle.rst (Sphinx)=> Doc/build/html/library/idle.html (help.copy_strip)=> Lib/idlelib/help.html

@bedevere-app
Copy link

bedevere-appbot commented Jun 11, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevnsobolevn mentioned this pull request Jun 11, 2024
Open
@xyb
Copy link
ContributorAuthor

xyb commented Jun 12, 2024

@sobolevn I've removed the changes of help.html to leave it to issue #120360. Please take a look, thanks.

@sobolevnsobolevn enabled auto-merge (squash) June 12, 2024 11:56
@sobolevnsobolevn merged commit ce3879b into python:mainJun 12, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented Jun 12, 2024

Thanks @xyb for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented Jun 12, 2024

Sorry, @xyb and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ce3879bd45e068f8e2a5a214acd234ca44cad53b 3.13

@miss-islington-app
Copy link

miss-islington-appbot commented Jun 12, 2024

Sorry, @xyb and @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ce3879bd45e068f8e2a5a214acd234ca44cad53b 3.12

@sobolevn
Copy link
Member

sobolevn commented Jun 12, 2024

@xyb would you please create manual backport PRs?

@xybxyb deleted the fixtypos branch June 13, 2024 03:02
@xyb
Copy link
ContributorAuthor

xyb commented Jun 13, 2024

@xyb would you please create manual backport PRs?

Sure, I'll be working on it soon.

@bedevere-app
Copy link

bedevere-appbot commented Jun 13, 2024

GH-120438 is a backport of this pull request to the 3.13 branch.

xyb added a commit to xyb/cpython that referenced this pull request Jun 13, 2024
@xyb
[3.13] Fix typos in documentation (pythonGH-120338)
0ad83f1
(cherry picked from commit ce3879b) Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jun 13, 2024
@bedevere-app
Copy link

bedevere-appbot commented Jun 13, 2024

GH-120439 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Jun 13, 2024
sobolevn pushed a commit that referenced this pull request Jun 13, 2024
@xyb
[3.12] Fix typos in documentation (GH-120338) (#120439)
0976c9f
(cherry picked from commit ce3879b)
sobolevn pushed a commit that referenced this pull request Jun 13, 2024
@xyb
[3.13] Fix typos in documentation (GH-120338) (#120438)
9c7ac7d
(cherry picked from commit ce3879b)
@terryjreedy
Copy link
Member

terryjreedy commented Jun 15, 2024

Sorry, my networking was down for a week. Thanks for doing the backports. I am looking at the help.html issue.

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@xyb@mrahtz
Fix typos in documentation (python#120338)
f06aa10
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@xyb@noahbkim
Fix typos in documentation (python#120338)
b4c964e
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@xyb@estyxx
Fix typos in documentation (python#120338)
5caf964
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@sobolevnsobolevnsobolevn approved these changes

@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy is a code owner

Assignees

@sobolevnsobolevn

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xyb@sobolevn@terryjreedy@serhiy-storchaka