Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jun 12, 2024

(cherry picked from commit 0e8d35b)

@serhiy-storchaka
Copy link
MemberAuthor

https://github.com/python/cpython-source-deps/archive/refs/tags/tix-8.4.3.6.tar.gz does not exist. But this reference is not changed in this PR!

@serhiy-storchaka
Copy link
MemberAuthor

https://github.com/python/cpython-source-deps/archive/refs/tags/tix-8.4.3.6.tar.gz does not exist. But this reference is not changed in this PR!

It exists. The problem must be anywhere else.

@zware
Copy link
Member

It looks to me like Tix compatibility finally broke in Tcl/Tk 8.6.14. I don't think it's worthwhile to try to fix Tix (which is removed from Python 3.13+ and deprecated in 3.6-3.12); I'll leave it up to your judgement whether to disable the test or skip the Tcl/Tk update on 3.12.

@zware
Copy link
Member

Oh, wait. I think it's because our 8.6.14 binary package doesn't include Tix.

I'm still not sure it's worthwhile to fix.

@zware
Copy link
Member

I'm somewhat out of the loop here; how impactful is the update to Tcl/Tk 8.6.14 on Windows? Is it worth @zooba's time creating a +tix binary package just for 3.12? I'm afraid we can't get away with dropping Tix at this point in the 3.12 cycle.

@serhiy-storchaka
Copy link
MemberAuthor

There are plentiful of changes in 8.6.14 in comparison with previous bugfixes.

@zooba
Copy link
Member

zooba commented Aug 5, 2024

Do we need to create it or can we just copy it into the latest branch (and update the tag)?

@serhiy-storchaka
Copy link
MemberAuthor

The main problem is that we need to build Tix for it.

@zooba
Copy link
Member

Tix has no dependencies, so it should be fine with the last built one. I can copy it into our 8.6.14 build and tag a new .1 version, or would you prefer 8.6.15?

@serhiy-storchaka
Copy link
MemberAuthor

I think it may be easier to go right to 8.6.15.

@zooba
Copy link
Member

Okay, there's an 8.6.15.1 available now that has the Tix libs added. No other changes, so no need to update newer versions.

@serhiy-storchakaserhiy-storchaka deleted the backport-0e8d35b-3.12 branch October 21, 2024 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@zware@zooba@erlend-aasland