gh-119146: Update `regexp` in `build.yml` to not trigger the jobs on `.md` and `.ini` files.#120435

Eclips4 · 2024-06-12T20:08:26Z

Issue: Update paths in jit.yml #119146

Eclips4 · 2024-06-12T20:34:50Z

@hugovk
So, these wildcard patterns actually work and the jit workflow is skipped, but other workflows don't take these exceptions into account.

savannahostrowski

The commit messages are so relatable 😅 . Testing GHA workflows is always such a pain. This LGTM!

.github/workflows/build.yml

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk

Thanks! Shall we also backport to 3.12?

miss-islington-app · 2024-06-13T11:38:34Z

Thanks @Eclips4 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…jobs on `*.md` and `*.ini` files. (pythonGH-120435) (cherry picked from commit ca5108a) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app · 2024-06-13T11:38:46Z

GH-120447 is a backport of this pull request to the 3.13 branch.

… jobs on `*.md` and `*.ini` files. (GH-120435) (#120447) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Eclips4 · 2024-06-13T12:21:29Z

Thanks! Shall we also backport to 3.12?

I think yes. #119147 wasn't backported to 3.12 because it was related to JIT workflow which appeared only in 3.13.
This PR does a more generally thing, so I think it would be ok to backport it to 3.12.

miss-islington-app · 2024-06-13T12:21:49Z

Thanks @Eclips4 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

…jobs on `*.md` and `*.ini` files. (pythonGH-120435) (cherry picked from commit ca5108a) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app · 2024-06-13T12:22:00Z

GH-120448 is a backport of this pull request to the 3.12 branch.

… jobs on `*.md` and `*.ini` files. (GH-120435) (#120448) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

…jobs on `*.md` and `*.ini` files. (python#120435) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

first try to fix that
f45af4b

Eclips4 requested a review from brandtbucher as a code owner June 12, 2024 20:08

bedevere-appbot mentioned this pull request Jun 12, 2024
Update paths in jit.yml#119146
Closed

bedevere-appbot added the awaiting review label Jun 12, 2024

Eclips4 marked this pull request as draft June 12, 2024 20:09

bedevere-appbot removed the awaiting review label Jun 12, 2024

Eclips4 added 3 commits June 12, 2024 20:14

second try to fix that
54cba29

third try to fix that
dd4445e

is the first option resolves that?
d0ea26e

Eclips4 mentioned this pull request Jun 12, 2024
gh-120433: Mention chocolatey for installing llvm on Windows as an alternative option #120434
Merged

Remove all of my changes
7189466

Eclips4 added 7 commits June 12, 2024 20:39

fourth try to fix that
943de2b

Is this really working?
a9dec9b

Revert my changes to make sure
d5936ad

Change the regex
a4ff900

oh..
b978473

another try
ecd9cd7

let's try this
4229dbe

Eclips4 added the skip news label Jun 12, 2024

Eclips4 added 10 commits June 12, 2024 21:09

this should work
c7d9294

and this
a9f3ecc

I guess this is the final commit
cfb1f8a

i hate this regex
52134ee

please
4c8508a

...
7317379

Seems I finally found the solution
46a20f9

try to trigger workflo
06b8b72

Yes, it's works!
b578b69

Last commit.
d477365

Eclips4 requested a review from savannahostrowski June 12, 2024 21:46

Eclips4 changed the title ~~gh-119146: Move wildcard patterns to top~~gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files.Jun 12, 2024

Eclips4 added the needs backport to 3.13 bugs and security fixes label Jun 12, 2024

savannahostrowski approved these changes Jun 13, 2024
View reviewed changes

bedevere-appbot added awaiting core review and removed awaiting review labels Jun 13, 2024

hugovk reviewed Jun 13, 2024
View reviewed changes

.github/workflows/build.yml Outdated Show resolvedHide resolved

Update .github/workflows/build.yml
8a799d7
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk approved these changes Jun 13, 2024
View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels Jun 13, 2024

hugovk merged commit ca5108a into python:mainJun 13, 2024

bedevere-appbot removed the awaiting merge label Jun 13, 2024

bedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jun 13, 2024

Eclips4 added the needs backport to 3.12 only security fixes label Jun 13, 2024

bedevere-appbot removed the needs backport to 3.12 only security fixes label Jun 13, 2024

Eclips4 deleted the issue-119146 branch June 13, 2024 12:39

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
6ecd9b3
…jobs on `*.md` and `*.ini` files. (python#120435) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
ce3b16a
…jobs on `*.md` and `*.ini` files. (python#120435) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

AA-Turner mentioned this pull request Feb 3, 2025
Convert change detection to a Python script #129627
Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-119146: Update `regexp` in `build.yml` to not trigger the jobs on `.md` and `.ini` files.#120435

gh-119146: Update `regexp` in `build.yml` to not trigger the jobs on `.md` and `.ini` files. #120435

Uh oh!

Eclips4 commented Jun 12, 2024•
edited by bedevere-app bot
Loading

Uh oh!

Eclips4 commented Jun 12, 2024

Uh oh!

savannahostrowski left a comment •
edited
Loading

Uh oh!

Uh oh!

hugovk left a comment

Uh oh!

miss-islington-appbot commented Jun 13, 2024

Uh oh!

bedevere-appbot commented Jun 13, 2024

Uh oh!

Eclips4 commented Jun 13, 2024

Uh oh!

miss-islington-appbot commented Jun 13, 2024

Uh oh!

bedevere-appbot commented Jun 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files.#120435

gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files. #120435

Uh oh!

Conversation

Eclips4 commented Jun 12, 2024• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eclips4 commented Jun 12, 2024

Uh oh!

savannahostrowski left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-appbot commented Jun 13, 2024

Uh oh!

bedevere-appbot commented Jun 13, 2024

Uh oh!

Eclips4 commented Jun 13, 2024

Uh oh!

miss-islington-appbot commented Jun 13, 2024

Uh oh!

bedevere-appbot commented Jun 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-119146: Update `regexp` in `build.yml` to not trigger the jobs on `.md` and `.ini` files.#120435

gh-119146: Update `regexp` in `build.yml` to not trigger the jobs on `.md` and `.ini` files. #120435

Eclips4 commented Jun 12, 2024•
edited by bedevere-app bot
Loading

savannahostrowski left a comment •
edited
Loading