gh-120635: Avoid leaking processes in test_pyrepl#120676
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes.
MemberAuthor
vstinner commented Jun 18, 2024
!buildbot AMD64 Debian PGO |
bedevere-bot commented Jun 18, 2024
Member
lysnikolaou commented Jun 18, 2024
Did the buildbot run? I can't find it in the list of checks. |
MemberAuthor
vstinner commented Jun 18, 2024
No, it didn't yet. It's very slow: a single build takes between 3 and 7 hours! https://buildbot.python.org/all/#/workers/3 |
MemberAuthor
vstinner commented Jun 19, 2024
It's a success. |
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2024
) If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes. (cherry picked from commit 0f3e364) Co-authored-by: Victor Stinner <[email protected]>
GH-120741 is a backport of this pull request to the 3.13 branch. |
vstinner added a commit that referenced this pull request Jun 19, 2024
…120741) gh-120635: Avoid leaking processes in test_pyrepl (GH-120676) If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes. (cherry picked from commit 0f3e364) Co-authored-by: Victor Stinner <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes.