Skip to content

Conversation

@nineteendo
Copy link
Contributor

@nineteendonineteendo commented Jun 18, 2024

0:00:33 load avg: 2.57 [ 61/478] test_interpreters ran no tests -- running (1): test_subprocess (31.8 sec) ---------------------------------------------------------------------- Ran 0 tests in 0.000s NO TESTS RAN 

@nineteendo
Copy link
ContributorAuthor

cc @vstinner

@vstinner
Copy link
Member

Can you please elaborate?

@nineteendo
Copy link
ContributorAuthor

nineteendo commented Jun 18, 2024

Same issue as here: #120660 (comment). test_interpreters isn't skipped properly:

1 test run no tests: test_interpreters 

This is distracting when reading through the logs and the same change you asked me to make (mine didn't even work).

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FWIW, the skipping should be removed in the near future. (See #117953 (comment).) However, fixing this in the meantime makes sense.

@vstinner
Copy link
Member

Should the change be backported to the 3.13 branch?

@nineteendo

This comment was marked as outdated.

@vstinnervstinner merged commit 1035fe0 into python:mainJun 18, 2024
@vstinner
Copy link
Member

Merged, thanks.

@nineteendonineteendo deleted the skip-test_interpreters-without-gil branch June 18, 2024 15:30
@ericsnowcurrently
Copy link
Member

gh-118157 was merged before the feature freeze, thus it is part of the 3.13 branch. Backporting this would make sense.

@ericsnowcurrentlyericsnowcurrently added the needs backport to 3.13 bugs and security fixes label Jun 18, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
…nGH-120689) (cherry picked from commit 1035fe0) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app
Copy link

GH-120707 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jun 18, 2024
@nineteendo
Copy link
ContributorAuthor

nineteendo commented Jun 18, 2024

Hmm, should we include the version in the title of all pull requests? [3.14] gh-117953: Skip `test_interpreters` properly without GIL. That would make it easier to determine in which version something was added.

ericsnowcurrently pushed a commit that referenced this pull request Jun 18, 2024
…20707) (cherry picked from commit 1035fe0, AKA gh-120689) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@ericsnowcurrently
Copy link
Member

I'm not sure it would be worth it. The time interval in which there's any uncertainty is relatively small and the target version for a PR against main can shift depending on how long its open. It isn't too hard to see if a commit (from a PR) is included in a specific release branch (or tag).

@nineteendo
Copy link
ContributorAuthor

OK, probably not worth it. I just feel bad for making a mistake because of it.

@ericsnowcurrently
Copy link
Member

There's nothing to feel bad about! We figured it out pretty quickly and even if we hadn't, it wouldn't have been a big deal.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nineteendo@vstinner@ericsnowcurrently