gh-120838: Disallow Py_Finalize() if Py_RunMain() is Running#120841
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
ericsnowcurrently commented Jun 21, 2024
@ncoghlan, any objections to this change? |
MemberAuthor
ericsnowcurrently commented Jun 21, 2024
CC @vstinner |
This reverts commit d5dc13a.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_RunMain()is responsible for finalizing the runtime. Extension modules should never callPy_Finalize(). Enforcing this helps keep finalization conceptually simpler and helps get closer to making thePy_Finalize()implementation simpler in practice.Note that the relevant docs change is part of gh-120839.