[3.13] gh-120782: Update internal type cache when reloading datetime (GH-120829)#120855
+39 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When reloading _datetime module, the single-phase version did not invoke the PyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.
This was referenced Jun 21, 2024
ContributorAuthor
neonene commented Jun 21, 2024
JelleZijlstra approved these changes Jun 21, 2024
ContributorAuthor
@ericsnowcurrently I backported e6076d1 as well. (I can take back the change: 09ec032) |
kumaraditya303 approved these changes Jul 3, 2024
ContributorAuthor
neonene commented Jul 3, 2024
Thanks. |
Contributor
freakboy3742 commented Jul 4, 2024
This backport appears to have broken the iOS buildbot. I’m AFK for the next week; I’ll take a look when I’m back at my desk. |
ContributorAuthor
neonene commented Jul 10, 2024
#121561 should be effective for fixing it. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reloading
_datetimemodule, the single-phase version did not invoke thePyInit__datetimefunction, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.This PR is a manual backport of a81d434, adding
assertstatements to the test case.This also backports e6076d1 (gh-120180) manually.
test_datetimefails with a--foreverargument #120782