gh-120937: Reference weakref from the __del__ documentation#120940
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The weakref documentation refers to __del__, but not the other way around.
All commit authors signed the Contributor License Agreement. |
hugovk reviewed Jun 25, 2024
Uh oh!
There was an error while loading. Please reload this page.
hugovk added needs backport to 3.12 hugovk approved these changes Jun 26, 2024
Eclips4 approved these changes Jun 26, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
…ythonGH-120940) (cherry picked from commit 1c13b29) Co-authored-by: chaen <christophe.haen@cern.ch> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-121061 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
…ythonGH-120940) (cherry picked from commit 1c13b29) Co-authored-by: chaen <christophe.haen@cern.ch> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-121062 is a backport of this pull request to the 3.12 branch. |
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
…ython#120940) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…ython#120940) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…ython#120940) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#120937
The weakref documentation refers to
__del__, but not the other way around.I am not sure the phrasing (copy/paste from weakref doc) is the best one, but it seems important to me redirect developers to what they are most probably looking for.
📚 Documentation preview 📚: https://cpython-previews--120940.org.readthedocs.build/