Skip to content

Conversation

@nohlson
Copy link
Contributor

@nohlsonnohlson commented Jun 26, 2024

Until tooling is implemented remove -Wimplicit-fallthrough compiler flag from BASEFLAGS

Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@corona10corona10 changed the title gh-#121040: Remove fallthrough warningsgh-121040: Remove fallthrough warningsJun 26, 2024
@corona10corona10 enabled auto-merge (squash) June 26, 2024 09:45
@corona10corona10 disabled auto-merge June 26, 2024 09:45
@corona10corona10 enabled auto-merge (squash) June 26, 2024 09:45
@corona10corona10 changed the title gh-121040: Remove fallthrough warningsgh-121040: Remove fallthrough warnings compiler optionJun 26, 2024
@corona10corona10 merged commit ef28f6d into python:mainJun 26, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nohlson@corona10