Skip to content

gh-121040: Use __attribute__((fallthrough))#121044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 6 commits into from
Jun 27, 2024
Merged

gh-121040: Use __attribute__((fallthrough)) #121044

vstinner merged 6 commits into from
Jun 27, 2024

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jun 26, 2024•
edited by bedevere-app bot
Loading

Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses attribute((fallthrough)) if available.

Fix warnings when using -Wimplicit-fallthrough compiler flag.

@vstinner
pythongh-121040: Use __attribute__((fallthrough))
bb2eb56
Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Fix warnings when using -Wimplicit-fallthrough compiler flag.
@bedevere-appbedevere-appbot mentioned this pull request Jun 26, 2024
Closed
@vstinner
Copy link
MemberAuthor

vstinner commented Jun 26, 2024

cc @sobolevn

sobolevn
sobolevn reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to run make regen-cases (or maybe even make regen-all) :)

@vstinner
Copy link
MemberAuthor

vstinner commented Jun 26, 2024

Looks like you need to run make regen-cases (or maybe even make regen-all) :)

Done.

@mdboom
Copy link
Contributor

mdboom commented Jun 26, 2024

Maybe of interest to @nohlson.

AlexWaygood
AlexWaygood reviewed Jun 26, 2024
View reviewed changes
@vstinner
Add _Py__has_attribute() macro
3bfdbf6
No longer define __has_attribute() if it's not defined. Move also _Py__has_builtin() at the top of pyport.h.
ericsnowcurrently
ericsnowcurrently approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left one small comment where you might consider a slightly different spelling, but I'll leave that up to you.

@brettcannonbrettcannon removed their request for review June 26, 2024 17:35
@vstinnervstinner enabled auto-merge (squash) June 27, 2024 09:38
@vstinner
Copy link
MemberAuthor

vstinner commented Jun 27, 2024

I tested my change with -Wimplicit-fallthrough=5 which ignores all comments. There are only remaining comments on Modules/expat/ when --with-system-expat is not used, not in the Python code base anymore.

See also the article about the flag: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7

@vstinnervstinner merged commit 12af8ec into python:mainJun 27, 2024
@vstinnervstinner deleted the fallthrough branch June 27, 2024 09:58
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner@sobolevn@mrahtz
pythongh-121040: Use __attribute__((fallthrough)) (python#121044)
638d523
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner@sobolevn@noahbkim
pythongh-121040: Use __attribute__((fallthrough)) (python#121044)
0deef4f
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner@sobolevn@estyxx
pythongh-121040: Use __attribute__((fallthrough)) (python#121044)
f1286b8
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
@ZeroIntensityZeroIntensity mentioned this pull request Jan 16, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@tirantiranAwaiting requested review from tiran

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner@mdboom@ericsnowcurrently@sobolevn@corona10@AlexWaygood