gh-121196: Document dict.fromkeys params as pos-only#121197
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bedevere-appbot added docs 
terryjreedy added needs backport to 3.12 
Member
terryjreedy commented Jul 1, 2024
Doc patches usually get backported when applicable, especially if they automerge. |
Contributor
erlend-aasland commented Jul 1, 2024
I would prefer to update the whole |
MemberAuthor
sobolevn commented Jul 1, 2024
@erlend-aasland I think that it is complicated. So, I would prefer to have a smaller scope for this change. |
hugovk approved these changes Jul 1, 2024
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
GH-121242 is a backport of this pull request to the 3.13 branch. |
MemberAuthor
sobolevn commented Jul 1, 2024
Thanks everyone! |
sobolevn added needs backport to 3.12 Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please, consider that some subtypes of
dictchange the signature back to pos-or-keyword args.But, since this is only about
dict, I guess we can be very specific about it.Do we backport this change?
dict.fromkeysmust mark its parameters as pos-only #121196📚 Documentation preview 📚: https://cpython-previews--121197.org.readthedocs.build/