Skip to content

Conversation

@ayappanec
Copy link
Contributor

@ayappanecayappanec commented Jul 2, 2024

This PR is to fix the problem mentioned in the issue #121045.
-fstack-protector-strong is not supported in AIX for gcc compiler and it actually requires a run/link check rather than a compile check to confirm it. And also there is no plan as of now to make it supported in AIX for gcc.

@ayappanec
Copy link
ContributorAuthor

I didn't add NEWS entry as this is a minor change.

@corona10
Copy link
Member

cc @nohlson

@ayappanec
Copy link
ContributorAuthor

Any update on this ?

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard-coding this to the AIX platform, I would prefer if we could instead rewrite the check to also run the linker, so it would fail on any platform that requires the linker step in order to determine support for this flag. Maybe a configure macro similar to PY_CHECK_CC_WARNING should be added: PY_CHECK_CC_FLAG?

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ayappanec
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@ayappanec
Copy link
ContributorAuthor

Kindly requesting for reviews

@erlend-aasland
Copy link
Contributor

Kindly requesting for reviews

Sorry, my bandwidth is low these days; I won't be able to revisit these for the next few weeks. Ping me again mid August if I don't get back to you. Thanks for your patience.

@ayappanecayappanec changed the title gh-121045: Disable -fstack-protector-strong for gcc compiler in AIXgh-121045: Use link test to check whether -fstack-protector-strong worksAug 1, 2024
@ayappanec
Copy link
ContributorAuthor

@erlend-aasland

@ayappanec
Copy link
ContributorAuthor

Kindly requesting for reviews

1 similar comment
@ayappanec
Copy link
ContributorAuthor

Kindly requesting for reviews

@ayappanec
Copy link
ContributorAuthor

Closing this PR as it is not getting any attention. Also I think the best way to address this issue is to fix the gcc compiler in AIX, so that during compile stage only (-c) it should fail when -fstack-protector-strong is passed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ayappanec@corona10@erlend-aasland