gh-121272: compiler no longer modifies the symtable, ste_coroutine always set during symtable construction#121297
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iritkatriel requested review from JelleZijlstra, carljm and markshannon as code owners
iritkatriel commented Jul 2, 2024
| compiler_exit_scope(c); | ||
| if (is_top_level_await && is_async_generator){ | ||
| c->u->u_ste->ste_coroutine = 1; | ||
| assert(c->u->u_ste->ste_coroutine == 1); |
MemberAuthor
There was a problem hiding this comment.
I believe this assignment has been obsolete for a while now, see #6766 (comment).
JelleZijlstra approved these changes Jul 2, 2024
Member
JelleZijlstra left a comment
JelleZijlstra left a comment There was a problem hiding this comment.
Agree this is a job for the symtable, not the compiler. This looks to be well tested in test_compile_top_level_await in test_builtin.py.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…on#121297) compiler no longer modifies the symtable after this.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…on#121297) compiler no longer modifies the symtable after this.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.