gh-121381 Remove subprocess._USE_VFORK escape hatch#121383
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This flag was added as an escape hatch in pythongh-91401 and backported to Python 3.10. The flag broke at some point between its addition and now. As there is currently no publicly known environments that require this, remove it rather than work on fixing it. This leaves the flag in the subprocess module to not break code which may have used / checked the flag itself. discussion: https://discuss.python.org/t/subprocess-use-vfork-escape-hatch-broken-fix-or-remove/56915/2
cmaloney changed the title cmaloneyforce-pushed the cmaloney/rm_use_vfork branch from 8dba0d8 to d19dd0cCompare
vstinner reviewed Jul 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
vstinner approved these changes Jul 8, 2024
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM.
The glibc posix_spawn() can use vfork() automatically and there is no option to control it. I don't think that Python users have to decide if vfork() is used or not. At least, I don't know any good reason to disable vfork() in subprocess.
hauntsaninja approved these changes Jul 31, 2024
Contributor
hauntsaninja commented Jul 31, 2024
Thank you! |
5 tasks
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
) This flag was added as an escape hatch in pythongh-91401 and backported to Python 3.10. The flag broke at some point between its addition and now. As there is currently no publicly known environments that require this, remove it rather than work on fixing it. This leaves the flag in the subprocess module to not break code which may have used / checked the flag itself. discussion: https://discuss.python.org/t/subprocess-use-vfork-escape-hatch-broken-fix-or-remove/56915/2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag was added as an escape hatch in bpo-47245 and backported to Python 3.10. The flag broke at some point between its addition and now. As there is currently no publicly known environments that require this, remove it rather than work on fixing it.
discussion: https://discuss.python.org/t/subprocess-use-vfork-escape-hatch-broken-fix-or-remove/56915/2
📚 Documentation preview 📚: https://cpython-previews--121383.org.readthedocs.build/