Skip to content

gh-121528: Fix the process crash when load extension when it's compiled with low version of the python.#121550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zheaoli wants to merge 5 commits into from
Closed

gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. #121550

Zheaoli wants to merge 5 commits into from

Conversation

@Zheaoli
Copy link
Contributor

@ZheaoliZheaoli commented Jul 9, 2024•
edited by bedevere-app bot
Loading

@ZheaoliZheaoli changed the title gh121528: Fix the process crash when load extension when it's compiled with low version of the python.gh-121528: Fix the process crash when load extension when it's compiled with low version of the python.Jul 9, 2024
@bedevere-appbedevere-appbot mentioned this pull request Jul 9, 2024
Closed
ZeroIntensity
ZeroIntensity requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this PR fixes #121528

@ZeroIntensity
Copy link
Member

ZeroIntensity commented Jul 9, 2024

@Eclips4 Can you add the 3.13 backport label?

@Eclips4Eclips4 added the needs backport to 3.13 bugs and security fixes label Jul 10, 2024
@Eclips4
Copy link
Member

Eclips4 commented Jul 10, 2024

cc @mgorny can you confirm that this patch fixes the issue?

@mgorny
Copy link
Contributor

mgorny commented Jul 10, 2024

I can confirm that rustworkx no longer crashes with this patch applied.

ZeroIntensity
ZeroIntensity requested changes Jul 10, 2024
View reviewed changes
@Zheaoli
Copy link
ContributorAuthor

Zheaoli commented Jul 10, 2024•
edited
Loading

@ZeroIntensity Thanks for the nits!

ZeroIntensity
ZeroIntensity approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM.

@ZheaoliZheaoli closed this Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees

No one assigned

Labels

awaiting core reviewneeds backport to 3.13bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[3.13] _PyObject_Init() assertion fails with the stable ABI on Python built with assertions (extension built with Python 3.11)

4 participants

@Zheaoli@ZeroIntensity@Eclips4@mgorny