Skip to content

gh-121637: Syntax error for optimized-away incorrect await#121656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 10 commits into from
Jul 22, 2024
Merged

gh-121637: Syntax error for optimized-away incorrect await #121656

JelleZijlstra merged 10 commits into from
Jul 22, 2024

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented Jul 13, 2024•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jul 13, 2024
Closed
@JelleZijlstraJelleZijlstra changed the title gh-121637: Syntax error for optimized-away incorrect await'gh-121637: Syntax error for optimized-away incorrect awaitJul 13, 2024
picnixz
picnixz reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@JelleZijlstraJelleZijlstra marked this pull request as draft July 13, 2024 01:40
@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented Jul 13, 2024

@picnixz while you're here, would you mind emailing me ([email protected]) or sending me a DM on https://discuss.python.org/u/jelle? I have something I want to ask you.

@JelleZijlstraJelleZijlstra marked this pull request as ready for review July 13, 2024 02:04
@picnixz
Copy link
Member

picnixz commented Jul 13, 2024

while you're here, would you mind emailing me

Well.. I just went to sleep at that time. I've just sent you an email, tell me if you didn't receive it!

picnixz
picnixz reviewed Jul 17, 2024
View reviewed changes
iritkatriel
iritkatriel approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good change.

picnixz
picnixz reviewed Jul 22, 2024
View reviewed changes
iritkatriel
iritkatriel reviewed Jul 22, 2024
View reviewed changes
@JelleZijlstraJelleZijlstra merged commit 2762c6c into python:mainJul 22, 2024
@JelleZijlstraJelleZijlstra deleted the toplevelawait branch July 22, 2024 21:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@picnixzpicnixzpicnixz left review comments

@carljmcarljmAwaiting requested review from carljmcarljm is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@picnixz@iritkatriel