Move macOS matrix to the calling workflow#121809
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
webknjazforce-pushed the maintenance/gha-macos-reusable-collapse branch from be9f8a3 to 41db579ComparePreviously, part of it was passed to the reusable workflow where another part was being populated. Now, the entire matrix is defined in a single place, in the calling workflow.
It is a DRY exercise, they were almost the same and there is no reason to keep them separate in YAML.
webknjazforce-pushed the maintenance/gha-macos-reusable-collapse branch from 41db579 to 2e1632eCompare
hugovk changed the title 
hugovk reviewed Jul 25, 2024
Uh oh!
There was an error while loading. Please reload this page.
hugovk added needs backport to 3.12 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Member
hugovk commented Jul 25, 2024
Thanks again! |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2024
(cherry picked from commit 1d607fe) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sorry, @webknjaz and @hugovk, I could not cleanly backport this to |
GH-122297 is a backport of this pull request to the 3.13 branch. |
hugovk added a commit that referenced this pull request Jul 25, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Jul 26, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit to hugovk/cpython that referenced this pull request Jul 26, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 26, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>. (cherry picked from commit 1d607fe) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
GH-122330 is a backport of this pull request to the 3.12 branch. |
Mapuppy09 commented Jul 27, 2024
Change Azure to Github , thank you! |
hugovk pushed a commit that referenced this pull request Jul 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, part of it was passed to the reusable workflow where
another part was being populated. Now, the entire matrix is defined
in a single place, in the calling workflow.