Skip to content

gh-121834: Improve complex C-API docs#121835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sobolevn merged 6 commits into from
Jul 17, 2024
Merged

gh-121834: Improve complex C-API docs #121835

sobolevn merged 6 commits into from
Jul 17, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Jul 16, 2024•
edited by github-actions bot
Loading

cc @skirpichev

I unified exception messages for NULL and -1.0 cases separatelly.

📚 Documentation preview 📚: https://cpython-previews--121835.org.readthedocs.build/

@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news labels Jul 16, 2024
@bedevere-appbedevere-appbot mentioned this pull request Jul 16, 2024
Closed
@sobolevnsobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 16, 2024
skirpichev
skirpichev approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@skirpichevskirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sobolevnand others added 3 commits July 16, 2024 10:26
@sobolevn@skirpichev
Update Doc/c-api/complex.rst
5ead003
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@sobolevn
Add Py_complex members
62c402c
@sobolevn
Add Py_complex members
1bf9ae0
skirpichev
skirpichev reviewed Jul 16, 2024
View reviewed changes
@sobolevn
Copy link
MemberAuthor

sobolevn commented Jul 16, 2024

The build failure is not related, see #121766

@sobolevn
Copy link
MemberAuthor

sobolevn commented Jul 16, 2024

This looks fine:
Снимок экрана 2024-07-16 в 11 11 56

Thanks everyone!

skirpichev
skirpichev reviewed Jul 16, 2024
View reviewed changes
encukou
encukou reviewed Jul 16, 2024
View reviewed changes
@sobolevn@encukou
Update Doc/c-api/complex.rst
fbd0858
Co-authored-by: Petr Viktorin <encukou@gmail.com>
skirpichev
skirpichev reviewed Jul 16, 2024
View reviewed changes
@sobolevnsobolevn merged commit 72dccd6 into python:mainJul 17, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented Jul 17, 2024

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
@sobolevn@skirpichev
@encukou@miss-islington
pythongh-121834: ImprovecomplexC-API docs (pythonGH-121835)
5b8ee99
(cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
@sobolevn
Copy link
MemberAuthor

sobolevn commented Jul 17, 2024

Thanks everyone!

@miss-islington-app
Copy link

miss-islington-appbot commented Jul 17, 2024

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 72dccd60735b597e99c007a7b69210763a746877 3.12

@bedevere-app
Copy link

bedevere-appbot commented Jul 17, 2024

GH-121895 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024
@sobolevn
Copy link
MemberAuthor

sobolevn commented Jul 17, 2024

I will backport this to 3.12 manually.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jul 17, 2024
@sobolevn@skirpichev@encukou
[3.12]pythongh-121834: ImprovecomplexC-API docs (pythonGH-121835)
e11ca8e
(cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented Jul 17, 2024

GH-121897 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Jul 17, 2024
sobolevn added a commit that referenced this pull request Jul 17, 2024
@miss-islington@sobolevn
@skirpichev@encukou
[3.13]gh-121834: ImprovecomplexC-API docs (GH-121835) (#121895)
bcf1c70
gh-121834: Improve `complex` C-API docs (GH-121835) (cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
sobolevn added a commit that referenced this pull request Jul 17, 2024
@sobolevn@skirpichev@encukou
[3.12]gh-121834: ImprovecomplexC-API docs (GH-121835) (#121897)
6a19d22
* [3.12] gh-121834: Improve `complex` C-API docs (GH-121835) (cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments

@skirpichevskirpichevskirpichev approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

@sobolevnsobolevn

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@encukou@skirpichev@erlend-aasland