Skip to content

Conversation

@Yhg1s
Copy link
Member

Move misplaced blurb entries from "C_API" to "C API", and from "Core_and_Builtins" to "Core and Builtins".

"Core_and_Builtins" to "Core and Builtins".
@ambv
Copy link
Contributor

ambv commented Jul 17, 2024

Shouldn't this rename go the other way?

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blurb <= 1.1.0 wants the old names with spaces.

Blurb >= 1.2.0 can read directories both with spaces and with underscores.

If we merge that PR, we can close (or merge!) this PR.

If @Yhg1s wants to do it the old way for this release, let's merge this one.

@ambv
Copy link
Contributor

ambv commented Jul 17, 2024

I merged the release-tools PR.

@Yhg1s
Copy link
MemberAuthor

I already fixed this for 3.13.0b4 in a separate PR. I sent this PR to Hugo because this is his bailiwick now :)

@hugovk
Copy link
Member

Thanks! Let's leave it as is, new blurb can read from both.

After today's release is out, we can also merge python/blurb_it#332 and I'll post on Discuss to encourage people to upgrade their blurb CLI. Further down the line, we can add a pre-commit check to prevent creation of dirs with spaces.

@hugovkhugovk closed this Jul 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting mergedocsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Yhg1s@ambv@hugovk