GH-121970: Make DeprecatedRemoved a subclass of VersionChange#121971
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ange`` Also allow the ``.. versionremoved::`` directive to be used whilst we still support older versions of Sphinx.
AA-Turner added skip news needs backport to 3.12 # Conflicts: # Doc/tools/extensions/pyspecific.py
encukou reviewed Jul 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
encukou approved these changes Jul 19, 2024
Member
encukou left a comment
encukou left a comment There was a problem hiding this comment.
LGTM. I trust you that this uses the correct Sphinx APIs :)
I checked that it generates the same output (except timestamps and search index data), at least on my Sphinx v7.2.6
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
…ange`` (pythonGH-121971) (cherry picked from commit 898e90c) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
…ange`` (pythonGH-121971) (cherry picked from commit 898e90c) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-122019 is a backport of this pull request to the 3.13 branch. |
GH-122020 is a backport of this pull request to the 3.12 branch. |
AA-Turner added a commit that referenced this pull request Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The majority of the code was duplicated. A future improvement would be to add some sort of method to
VersionChangefor determining the version and labels that we could override in this subclass, rather than the somewhat convoluted method here.Also allow the
.. versionremoved::directive to be used whilst we still support older versions of Sphinx.A
pyspecific#121970📚 Documentation preview 📚: https://cpython-previews--121971.org.readthedocs.build/