gh-112301: -fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos#121979
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
corona10 commented Jul 19, 2024
see: #121996 (comment) |
kulikjakforce-pushed the Solaris-fstack-protector-fix branch from 16c3d48 to 5673fe7Compare
kulikjakforce-pushed the Solaris-fstack-protector-fix branch from 5673fe7 to cd9638aCompare
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linker on Solaris/Illumos is unhappy when you pass
-fstack-protector-strongflag viaCFLAGSbut notLDFLAGS, resulting in the following failure after #120975:I don't think that other links will mind, but I can certainly make this into a Solaris/Illumos specific
LDFLAGSappend.