Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Jul 18, 2024

  • Pre-populate HTML via the template rather than creating it via JavaScript
  • Extract the JavaScript to its own file
  • Use async/await in JS
  • Fix a potential bug if there are multiple glossary terms for one entry

A


📚 Documentation preview 📚: https://cpython-previews--121991.org.readthedocs.build/

Example: https://cpython-previews--121991.org.readthedocs.build/en/121991/search.html?q=qualified+name

@AA-TurnerAA-Turner added docs Documentation in the Doc dir skip news labels Jul 18, 2024
@AA-TurnerAA-Turner requested a review from hugovkJuly 18, 2024 22:15
@AA-TurnerAA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@hugovk
Copy link
Member

Merging in main to unstick the CI.

@AA-TurnerAA-Turner merged commit adf0b94 into python:mainJul 19, 2024
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@bedevere-app
Copy link

GH-122015 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
@bedevere-app
Copy link

GH-122016 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
) (#122016) GH-121970: Improve the glossary preview in HTML search (GH-121991) (cherry picked from commit adf0b94) Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 19, 2024
) (#122015) GH-121970: Improve the glossary preview in HTML search (GH-121991) (cherry picked from commit adf0b94) Co-authored-by: Adam Turner <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@hugovk