Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-120974: Make _asyncio._leave_task atomic in the free-threaded build#122139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120974: Make _asyncio._leave_task atomic in the free-threaded build #122139
Uh oh!
There was an error while loading. Please reload this page.
Conversation
colesbury commented Jul 22, 2024 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
…d build Update `_PyDict_DelItemIf` to allow for an argument to be passed to the predicate.
colesbury commented Jul 22, 2024
Like with #122138, this seems to slightly improve the performance of |
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @colesbury for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…d build (pythonGH-122139) * pythongh-120974: Make _asyncio._leave_task atomic in the free-threaded build Update `_PyDict_DelItemIf` to allow for an argument to be passed to the predicate. (cherry picked from commit a15fede) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-122186 is a backport of this pull request to the 3.13 branch. |
…ed build (GH-122139) (#122186) gh-120974: Make _asyncio._leave_task atomic in the free-threaded build (GH-122139) * gh-120974: Make _asyncio._leave_task atomic in the free-threaded build Update `_PyDict_DelItemIf` to allow for an argument to be passed to the predicate. (cherry picked from commit a15fede) Co-authored-by: Sam Gross <colesbury@gmail.com>
bedevere-bot commented Jul 23, 2024
|
…d build (python#122139) * pythongh-120974: Make _asyncio._leave_task atomic in the free-threaded build Update `_PyDict_DelItemIf` to allow for an argument to be passed to the predicate.
…d build (python#122139) * pythongh-120974: Make _asyncio._leave_task atomic in the free-threaded build Update `_PyDict_DelItemIf` to allow for an argument to be passed to the predicate.
Update
_PyDict_DelItemIfto allow for an argument to be passed to the predicate.asynciothread-safety issues in the free-threaded build #120974