Skip to content

gh-112301: Add macOS warning tracking tooling#122211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 35 commits into from
Aug 6, 2024
Merged

gh-112301: Add macOS warning tracking tooling #122211

hugovk merged 35 commits into from
Aug 6, 2024

Conversation

@nohlson
Copy link
Contributor

@nohlsonnohlson commented Jul 24, 2024•
edited by bedevere-app bot
Loading

Implement warning tracking for macOS GitHub Actions builds.

This tooling builds on #121730

check_warnings.py now takes an argument to parse compiler output of two types:

  • json from gcc using -fdiagnostic-format=json
  • generic clang compiler warning output

The macOS build and test job configuration is modified to write compiler output to a file and run the check_warnings.py tool.

nohlsonand others added 26 commits July 23, 2024 03:14
@nohlson
Create simple warning check tool and add to ubuntu build and test job
5148727
@nohlson
Add flags to check warnings script to fail on regression or improvement
3bd5a10
@nohlson
Remove redundant comment
6813003
@nohlson
Rename warnigore file to warningignore
ab4d754
@nohlson
Use regex to extract json arrays
615d228
@nohlson
Trim whitespace
fc0a60b
@nohlson
Test on github unexpected improvement
7793d80
@nohlson
Add config for improve fail check
99715d2
@nohlson
Revert to prod check warning state
bc44ec2
@blurb-it@nohlson
📜🤖 Added by blurb_it.
e2ca75f
@nohlson
Refactor creating set of files with warnings to a dedicated function
bd1634e
@nohlson
Move cflags configure option to top level build configuration
b07b1d6
@nohlson
Add json diagnostics to ubuntu configuration as first argument
e1954a5
@nohlson
Add newline to news
5935143
@nohlson
Create simple warning check tool and add to ubuntu build and test job
7f1a238
@nohlson
Add macos warning checks to GitHub actions
144136e
@nohlson
Revert reusable-macos.yml for environment variables
3dd40fd
@nohlson
Update paths
1158f53
@nohlson
Test unexpected improvement
cb51b4f
@nohlson
Remove warning ignore
77e0f6e
@nohlson
Add json output option to macos configure job
3e1d75f
@nohlson
Add common dictionary format when parsing warnings
b5cd58a
@nohlson
Remove configure option for macos job
02f313e
@nohlson
Print out json version of compiler output
83d1ed7
@nohlson
Remove old version of warning ignore file
08a6f6d
@nohlson
Remove compiler output print diagnostic
7be8ee6
@bedevere-appbedevere-appbot mentioned this pull request Jul 24, 2024
Open
@hugovkhugovk changed the title gh-112301: Add macos warning tracking toolinggh-112301: Add macOS warning tracking toolingJul 30, 2024
@hugovk
Copy link
Member

hugovk commented Jul 30, 2024

This has some conflicts now #121730 has been merged.

@nohlson
Copy link
ContributorAuthor

nohlson commented Jul 30, 2024

This has some conflicts now #121730 has been merged.

I have updated the script to included changes made in #121730

@nohlsonnohlson mentioned this pull request Jul 30, 2024
Merged
nohlson
nohlson commented Jul 31, 2024
View reviewed changes
hugovk
hugovk reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits :)

hugovk
hugovk reviewed Jul 31, 2024
View reviewed changes
@nohlson
Copy link
ContributorAuthor

nohlson commented Aug 5, 2024

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-appbot commented Aug 5, 2024

Thanks for making the requested changes!

: please review the changes made to this pull request.

@nohlsonnohlson mentioned this pull request Aug 6, 2024
Merged
hugovk
hugovk approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(The failing Hypothesis CI check is unrelated, and already fixed in main, we can ignore it here.)

@hugovkhugovk merged commit 58be1c2 into python:mainAug 6, 2024
@nohlsonnohlson mentioned this pull request Aug 7, 2024
Merged
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@nohlson@blurb-it@brandtbucher
pythongh-112301: Add macOS warning tracking tooling (python#122211)
1106378
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@nohlson@blurb-it@blhsing
pythongh-112301: Add macOS warning tracking tooling (python#122211)
d29a061
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nohlson@hugovk@JelleZijlstra