Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-121489: Export private _PyBytes_Join() again#122267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
cdce8p commented Jul 25, 2024 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
cdce8p commented Jul 25, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@encukou Seems we had a little misunderstanding here 😅 Sorry about that. Merging it into main and then backporting it to 3.13 was what I had in mind to begin with. |
encukou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be backported to 3.13 as the replacement is not available there.
I'll merge tomorrow if there are no objections.
Misc/NEWS.d/next/C API/2024-07-21-17-40-07.gh-issue-121489.SUMFCr.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit aef95eb) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
GH-122287 is a backport of this pull request to the 3.13 branch. |
bedevere-bot commented Jul 25, 2024
|
mhsmith commented Jul 26, 2024
@freakboy3742: The iOS buildbot has failed this way a few times now. It looks like it's specific to the datagram server test, rather than a random failure of networking in general. |
freakboy3742 commented Jul 26, 2024
@mhsmith Yes - I've seen that, but it appears to be a transient problem; subsequent builds work fine. I haven't been able to reproduce locally, but it appears to be related to load - it seems to coincide with longer than usual test runtimes. |
Followup from #121489 and #121646 (comment). Export the
_PyBytes_Join()again until the new publicPyBytes_Join()is added. If backported to3.13, this would make transitioning easier.This partially reverts #107144.
/CC @vstinner