Skip to content

GH-122155: Track local variables between pops and pushes in cases generator#122286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 13 commits into from
Aug 1, 2024
Merged

GH-122155: Track local variables between pops and pushes in cases generator #122286

markshannon merged 13 commits into from
Aug 1, 2024

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Jul 25, 2024•
edited by bedevere-app bot
Loading

The current design of the cases generator assumes that the code generator can infer all it needs to know from looking at the stack comments of individual micro-ops. However this isn't true within a tier 1 instruction if the intermediate stack grows during an instruction.

This PR tracks local values during micro ops, between them being popped from the stack and pushed back to the stack.

@bedevere-appbedevere-appbot mentioned this pull request Jul 25, 2024
Closed
squeaky-pl
squeaky-pl reviewed Jul 27, 2024
View reviewed changes
squeaky-pl
squeaky-pl reviewed Jul 27, 2024
View reviewed changes
picnixz
picnixz reviewed Jul 27, 2024
View reviewed changes
markshannonand others added 4 commits July 30, 2024 09:26
@markshannon@picnixz@squeaky-pl
Apply suggestions from code review
47f3bb3
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Paweł Piotr Przeradowski <showerproof86@gmail.com>
@markshannon
Use dict and tuple instead of Dict and Tuple in annotations
89fbf03
@markshannon
Minor tidy up
76a364f
@markshannon
Merge branch 'main' into cases-gen-track-locals
070786d
iritkatriel
iritkatriel reviewed Jul 31, 2024
View reviewed changes
@markshannon
Copy link
MemberAuthor

markshannon commented Aug 1, 2024

JIT failures are unrelated (an llvm package issue)

@markshannonmarkshannon merged commit a9d56e3 into python:mainAug 1, 2024
@colesburycolesbury mentioned this pull request Aug 2, 2024
Closed
@markshannonmarkshannon deleted the cases-gen-track-locals branch August 6, 2024 10:14
@colesburycolesbury mentioned this pull request Aug 6, 2024
Merged
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@markshannon@blhsing
pythonGH-122155: Track local variables between pops and pushes in cas…
e995f4a
…es generator (pythonGH-122286)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@iritkatrieliritkatrieliritkatriel approved these changes

+1 more reviewer

@squeaky-plsqueaky-plsqueaky-pl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon@squeaky-pl@iritkatriel@picnixz