Skip to content

gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call#122362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sobolevn merged 2 commits into from
Jul 27, 2024
Merged

gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call#122362

sobolevn merged 2 commits into from
Jul 27, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Jul 27, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jul 27, 2024
Closed
@sobolevnsobolevn mentioned this pull request Jul 27, 2024
Merged
picnixz
picnixz reviewed Jul 27, 2024
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?

JelleZijlstra
JelleZijlstra approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, thought I got all the warnings.

@sobolevnsobolevn merged commit 04eb5c8 into python:mainJul 27, 2024
@sobolevn
Copy link
MemberAuthor

sobolevn commented Jul 27, 2024

How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?

Oups, sorry, @picnixz, I missed this question!
I don't really think that it really matters in this use-case :)

@picnixz
Copy link
Member

picnixz commented Jul 27, 2024

No worry (I also don't think it matters (I didn't know in which context it was being used actually))

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@picnixz@JelleZijlstra