GH-120024: Refactor code a bit so that escaping calls can be wrapped in spill code in code generator#122693
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…de in code generator
iritkatriel approved these changes Aug 5, 2024
MemberAuthor
markshannon commented Aug 6, 2024
The 3 failures are know failures: Network issues on the emulated platforms and a hypothesis issue. |
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
…apped in spill code in code generator (pythonGH-122693)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…apped in spill code in code generator (pythonGH-122693)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preparatory refactoring for deferred reference counting.
We expect the code generator to spill the stack pointer and any necessary values to the stack around escaping calls.
But this is tricky if the call is embedded in a control flow statement.
This PR moves the calls out of control flow statements.
Changes code like
if (escaping_call(...)){intoint err = escaping_call(...); if (err){