gh-116622: Android logging fixes#122698
Merged
gh-116622: Android logging fixes #122698
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mhsmith added needs backport to 3.13 
Contributor
freakboy3742 left a comment
freakboy3742 left a comment There was a problem hiding this comment.
These changes all make sense to me; but there's a hypothesis test that is currently failing. I want to understand what's going on there before I formally approve/merge.
freakboy3742 approved these changes Aug 6, 2024
Contributor
freakboy3742 left a comment
freakboy3742 left a comment There was a problem hiding this comment.
Looks like the hypothesis failure is due to #122686, so I guess that makes this good to go!
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
Modifies the handling of stdout/stderr redirection on Android to accomodate the rate and buffer size limits imposed by Android's logging infrastructure. (cherry picked from commit b0c48b8) Co-authored-by: Malcolm Smith <smith@chaquo.com>
GH-122719 is a backport of this pull request to the 3.13 branch. |
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
Modifies the handling of stdout/stderr redirection on Android to accomodate the rate and buffer size limits imposed by Android's logging infrastructure.
Member
hugovk commented Aug 9, 2024
Hello! For next time, please could you update your blurb CLI? Thanks! https://discuss.python.org/t/new-blurb-1-2-please-upgrade/59159 |
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Modifies the handling of stdout/stderr redirection on Android to accomodate the rate and buffer size limits imposed by Android's logging infrastructure.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with Android's redirection of stdout and stderr to the Logcat, which was added in #118063:
The buffering behavior of TextIOWrapper was changed in #119507, which broke the technique we were previously using to stay within Logcat's line length limit. Since this behavior is not part of TextIOWrapper's public API, it's safer to bypass it completely and do the buffering ourselves.
When running in
--verbose3mode, I noticed that failure logs of large test modules liketest_pathlibwere truncated because they were being written faster than the test script could consume them. Fixed by adding a rate limit using the token bucket algorithm.The Android stdout and stderr tests themselves failed in
--verbose3mode because stdout and stderr were captured by aStringIO. Fixed by detecting this mode and using some temporary streams with the same properties.