gh-117139: Garbage collector support for deferred refcounting#122956
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* The free-threaded GC now visits interpreter stacks to keep objects that use deferred reference counting alive. * Interpreter frames are zero initialized in the free-threaded GC so that the GC doesn't see garbage data. This is a temporary measure until stack spilling around escaping calls is implemented. Co-authored-by: Ken Jin <kenjin@python.org>
ContributorAuthor
colesbury commented Aug 12, 2024
This was extracted from: |
DinoV approved these changes Aug 13, 2024
Python/gc_free_threading.c Outdated
| int | ||
| _PyGC_VisitFrameStack(_PyInterpreterFrame*frame, visitprocvisit, void*arg) | ||
| { | ||
| _PyStackRef*ref=frame->localsplus; |
Contributor
There was a problem hiding this comment.
Maybe use _PyFrame_GetLocalsArray like the GIL version just to be consistent?
colesbury added the 🔨 test-with-refleak-buildbots 
bedevere-bot commented Aug 13, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 5b9176b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 approved these changes Aug 15, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…ython#122956) The free-threaded GC now visits interpreter stacks to keep objects that use deferred reference counting alive. Interpreter frames are zero initialized in the free-threaded GC so that the GC doesn't see garbage data. This is a temporary measure until stack spilling around escaping calls is implemented. Co-authored-by: Ken Jin <kenjin@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The free-threaded GC now visits interpreter stacks to keep objects that use deferred reference counting alive.
Interpreter frames are zero initialized in the free-threaded GC so that the GC doesn't see garbage data. This is a temporary measure until stack spilling around escaping calls is implemented.