Skip to content

GH-118093: Specialize CALL_KW#123006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 12 commits into from
Aug 16, 2024
Merged

GH-118093: Specialize CALL_KW#123006

markshannon merged 12 commits into from
Aug 16, 2024

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Aug 14, 2024•
edited
Loading

According to our stats the CALL_KW opcode is one of the most common opcodes that prevents projection of tier 2 traces.
Making CALL_KW suitable for tier 2 is infeasible, but we can specialize it in tier 1 such that the specializations can be handled by tier 2.

This PR adds three specializations:

  • CALL_KW_PY for calls to Python functions
  • CALL_KW_BOUND_METHODS for calls to bound methods
  • CALL_KW_NON_PY for calls to everything else.

@bedevere-appbedevere-appbot mentioned this pull request Aug 14, 2024
Open
3 tasks
@markshannon
Copy link
MemberAuthor

markshannon commented Aug 15, 2024•
edited
Loading

No impact on performance
Stats show 99.9% specialization with a low (<1%) miss rate.

Fidget-Spinner
Fidget-Spinner reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Two questions.

iritkatriel
iritkatriel approved these changes Aug 16, 2024
View reviewed changes
@markshannon@iritkatriel
Update Include/internal/pycore_code.h
8b504ae
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@markshannonmarkshannon merged commit c13e7d9 into python:mainAug 16, 2024
@markshannonmarkshannon deleted the specialize-call-kw branch August 16, 2024 16:12
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@markshannon@jeremyhylton
pythonGH-118093: SpecializeCALL_KW(pythonGH-123006)
114fa0f
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@markshannon@blhsing
pythonGH-118093: SpecializeCALL_KW(pythonGH-123006)
eea2ba3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@iritkatriel@Fidget-Spinner