gh-99108: Inform HACL when explicit_bzero is unavailable#123027
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
mhsmith commented Aug 14, 2024
!buildbot RHEL7 |
bedevere-bot commented Aug 14, 2024
🤖 New build scheduled with the buildbot fleet by @mhsmith for commit c903381 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
msprotz approved these changes Aug 14, 2024
Contributor
msprotz left a comment
msprotz left a comment There was a problem hiding this comment.
Ok that makes a lot of sense. Thank you!
erlend-aasland approved these changes Aug 15, 2024
Member
encukou commented Aug 15, 2024
Thank you! |
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…nGH-123027) Inform HACL whether explicit_bzero is available
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context, see #99108 (comment).
This PR fixes the build on Android and RHEL7 by defining LINUX_NO_EXPLICIT_BZERO when
explicit_bzerois unavailable. It turns out there was already an autoconf check for this function, so I reused it.Instead of creating a new Makefile variable, I appended the definition to LIBHACL_CFLAGS. This may be useful if HACL uses it in other files in the future.