Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Aug 16, 2024

…o that codegen function don't need to set it on the code unit
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Bigmem 3.x has failed when building commit e077b20.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1079/builds/4575) and take a look at the build logs.
  4. Check if the failure is related to this commit (e077b20) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1079/builds/4575

Failed tests:

  • test_zipfile64

Failed subtests:

  • testStored - test.test_zipfile64.TestsWithSourceFile.testStored

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\runpy.py", line 198, in _run_module_as_mainreturn _run_code(code, main_globals, None, "__main__", mod_spec) File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\runpy.py", line 88, in _run_codeexec(code, run_globals) ~~~~^^^^^^^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\__main__.py", line 2, in <module> main(_add_python_opts=True) ~~~~^^^^^^^^^^^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\libregrtest\main.py", line 747, in main Regrtest(ns, _add_python_opts=_add_python_opts).main(tests=tests) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\libregrtest\main.py", line 739, in main exitcode =self.run_tests(selected, tests) File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\libregrtest\main.py", line 576, in run_testsreturnself._run_tests(selected, tests) ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\libregrtest\main.py", line 556, in _run_testsself.finalize_tests(coverage) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\libregrtest\main.py", line 454, in finalize_testsself.results.write_junit(self.junit_filename) ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\libregrtest\results.py", line 193, in write_junit f.write(s) ~~~~~~~^^^OSError: [Errno 28] No space left on device Traceback (most recent call last): File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_zipfile64.py", line 75, in testStoredself.zipTest(TESTFN2, zipfile.ZIP_STORED) ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_zipfile64.py", line 45, in zipTest zipfp.writestr("testfn%d"% num, self.data) ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\zipfile\__init__.py", line 1936, in writestr dest.write(data) ~~~~~~~~~~^^^^^^ File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\zipfile\__init__.py", line 1247, in writeself._fileobj.write(data) ~~~~~~~~~~~~~~~~~~~^^^^^^OSError: [Errno 28] No space left on device

jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
…o that codegen functions don't need to set it on the code unit (python#123078)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…o that codegen functions don't need to set it on the code unit (python#123078)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel@bedevere-bot@markshannon