[3.12] gh-99113: restore behaviour of PyThreadState_Swap#123079
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
in python#104208 it was inadvertently (?) changed to acquire the GIL
This was referenced Aug 16, 2024
ContributorAuthor
asottile commented Aug 16, 2024
hmmm given the test failures maybe this isn't the right approach. going to see if there's some UB in uwsgi first before approaching this more |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #104208 it was inadvertently (?) changed to acquire the GIL
for more context and a bisection see unbit/uwsgi#2659