Skip to content

gh-121404: rename functions to use codegen_* prefix. Use macros more consistently.#123139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 3 commits into from
Aug 19, 2024
Merged

gh-121404: rename functions to use codegen_* prefix. Use macros more consistently. #123139

iritkatriel merged 3 commits into from
Aug 19, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Aug 19, 2024•
edited by bedevere-app bot
Loading

@iritkatrieliritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 19, 2024
@bedevere-appbedevere-appbot mentioned this pull request Aug 19, 2024
Closed
picnixz
picnixz reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on a warning due to a conversion and some other nitpicking comments.

@iritkatrieliritkatriel enabled auto-merge (squash) August 19, 2024 14:36
@iritkatrieliritkatriel merged commit b6d0a40 into python:mainAug 19, 2024
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@iritkatriel@jeremyhylton
pythongh-121404: rename functions to use codegen_* prefix. Use macros…
16d98a3
… more consistently. (python#123139)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@iritkatriel@blhsing
pythongh-121404: rename functions to use codegen_* prefix. Use macros…
85f0f51
… more consistently. (python#123139)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@carljmcarljmAwaiting requested review from carljm

@jeremyhyltonjeremyhyltonAwaiting requested review from jeremyhylton

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel@JelleZijlstra@picnixz