Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
GH-118093: Make CALL_ALLOC_AND_ENTER_INIT suitable for tier 2.#123140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
markshannon commented Aug 19, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
CALL_ALLOC_AND_ENTER_INIT suitable for tier 2.CALL_ALLOC_AND_ENTER_INIT suitable for tier 2.markshannon commented Aug 20, 2024
Stats show a small increase in tier 2 uops executed and the elimination of |
Misc/NEWS.d/next/Core_and_Builtins/2024-08-19-15-13-13.gh-issue-118093.dLZ8qS.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…e-118093.dLZ8qS.rst
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Aug 20, 2024
|
bedevere-bot commented Aug 20, 2024
|
bedevere-bot commented Aug 20, 2024
|
bedevere-bot commented Aug 20, 2024
|
bedevere-bot commented Aug 20, 2024
|
encukou commented Aug 21, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
pythonGH-123140) * Convert CALL_ALLOC_AND_ENTER_INIT to micro-ops such that tier 2 supports it * Allow inexact arguments for CALL_ALLOC_AND_ENTER_INIT.
This PR:
1 Breaks
CALL_ALLOC_AND_ENTER_INITinto micro-ops, so that it can be included in tier 2 traces2 Relaxes the requirement exact arguments, so that more calls to Python classes are inlined.
3 Passes the
previousframe to the variousPyInterpreterFramecreation functions.(3) above seems more logical than setting the
previousfield separately, and is necessary to break upCALL_ALLOC_AND_ENTER_INITas it pushes two frames.