Skip to content

gh-121404: more compiler_* -> codegen_*, class_body and comprehensions#123262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 3 commits into from
Aug 23, 2024
Merged

gh-121404: more compiler_* -> codegen_*, class_body and comprehensions #123262

iritkatriel merged 3 commits into from
Aug 23, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Aug 23, 2024•
edited by bedevere-app bot
Loading

@picnixzpicnixz changed the title gh-121303: more compiler_* -> codegen_*, class_body and comprehensionsgh-121404: more compiler_* -> codegen_*, class_body and comprehensionsAug 23, 2024
@bedevere-appbedevere-appbot mentioned this pull request Aug 23, 2024
Closed
picnixz
picnixz reviewed Aug 23, 2024
View reviewed changes
iritkatrieland others added 2 commits August 23, 2024 14:54
@iritkatriel@picnixz
whitespace
2631385
Co-authored-by: Bénédikt Tran <[email protected]>
@iritkatriel
add assert
5d2229d
markshannon
markshannon reviewed Aug 23, 2024
View reviewed changes
Python/compile.c
#define IS_INTERACTIVE(C) compiler_is_interactive(C)
#define IS_NESTED_SCOPE(C) compiler_is_nested_scope(C)
#define SCOPE_TYPE(C) compiler_scope_type(C)
#define QUALNAME(C) compiler_qualname(C)
Copy link
Member

@markshannonmarkshannonAug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why you are adding this macro; it fits the pattern.

But OOI, why do we have all these macros in the first place?

Copy link
MemberAuthor

@iritkatrieliritkatrielAug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why originally, but I think it will be handy for customizing the compiler after I finish the split. We'll see.

markshannon
markshannon approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iritkatrieliritkatriel merged commit bf1b5d3 into python:mainAug 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@markshannonmarkshannonmarkshannon approved these changes

@carljmcarljmAwaiting requested review from carljm

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstra

@jeremyhyltonjeremyhyltonAwaiting requested review from jeremyhylton

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel@markshannon@picnixz