Skip to content

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Aug 24, 2024

This also makes _pylong no longer leak references due to the contextvars in decimal, although _pydecimal (and _decimal) will still leak once we call decimal.getcontext().

@picnixzpicnixz changed the title gh-123284: fix _pylong decimal context creation (and refleaks)gh-123284: fix _pylong decimal context creationAug 24, 2024
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is maybe hidden the problem, but I don't think that it's a fix: #123284 (comment)

I don't think that _pylong.py code is wrong.

@picnixzpicnixz marked this pull request as draft September 5, 2024 23:04
@picnixz
Copy link
MemberAuthor

Converting into draft until I solved the original issue.

@picnixz
Copy link
MemberAuthor

Actually, this will be fixed by #123703 because what's missing the Py_VISIT on the signals and cond maps.

@picnixzpicnixz closed this Sep 6, 2024
@picnixzpicnixz deleted the fix-pylong-refleaks branch September 6, 2024 11:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner