Skip to content

gh-82378: document the difference between sys.tracebacklimit and the limit arguments#123286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 3 commits into from
Aug 25, 2024
Merged

gh-82378: document the difference between sys.tracebacklimit and the limit arguments #123286

pablogsal merged 3 commits into from
Aug 25, 2024

Conversation

@cfbolz
Copy link
Contributor

@cfbolzcfbolz commented Aug 24, 2024•
edited by hugovk
Loading

@bedevere-appbedevere-appbot mentioned this pull request Aug 24, 2024
Closed
@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news awaiting core review labels Aug 24, 2024
@cfbolzcfbolz requested a review from pablogsalAugust 24, 2024 12:18
@pablogsal
Copy link
Member

pablogsal commented Aug 24, 2024

I think this is good but as this it's tricky territory I would like @hugovk to see if he can suggest any improvement to the location or the wording

picnixz
picnixz approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: removing a double space.

@cfbolz@picnixz
Update Doc/library/traceback.rst
0de4934
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@cfbolz
Copy link
ContributorAuthor

cfbolz commented Aug 25, 2024

@picnixz thanks!

hugovk
hugovk reviewed Aug 25, 2024
View reviewed changes
@cfbolz@hugovk
Update Doc/library/traceback.rst
a227ce5
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
hugovk approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pablogsalpablogsal merged commit 70bfef5 into python:mainAug 25, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented Aug 25, 2024

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
@cfbolz@miss-islington
pythongh-82378: Document the difference between sys.tracebacklimit an…
6c52b1d
…d the limit arguments (pythonGH-123286) (cherry picked from commit 70bfef5) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-app
Copy link

bedevere-appbot commented Aug 25, 2024

GH-123325 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Aug 25, 2024
@pablogsalpablogsal added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 25, 2024
@miss-islington-app
Copy link

miss-islington-appbot commented Aug 25, 2024

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented Aug 25, 2024

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
@cfbolz@miss-islington
pythongh-82378: Document the difference between sys.tracebacklimit an…
50260e9
…d the limit arguments (pythonGH-123286) (cherry picked from commit 70bfef5) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-app
Copy link

bedevere-appbot commented Aug 25, 2024

GH-123326 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
@cfbolz@miss-islington
pythongh-82378: Document the difference between sys.tracebacklimit an…
5ee8962
…d the limit arguments (pythonGH-123286) (cherry picked from commit 70bfef5) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Aug 25, 2024
pablogsal pushed a commit that referenced this pull request Aug 25, 2024
@miss-islington@cfbolz
[3.12]gh-82378: Document the difference between sys.tracebacklimit a…
ffa282c
…nd the limit arguments (GH-123286) (#123326) gh-82378: Document the difference between sys.tracebacklimit and the limit arguments (GH-123286) (cherry picked from commit 70bfef5) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
pablogsal pushed a commit that referenced this pull request Aug 25, 2024
@miss-islington@cfbolz
[3.13]gh-82378: Document the difference between sys.tracebacklimit a…
4817365
…nd the limit arguments (GH-123286) (#123325) gh-82378: Document the difference between sys.tracebacklimit and the limit arguments (GH-123286) (cherry picked from commit 70bfef5) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@hugovkhugovk removed the needs backport to 3.13 bugs and security fixes label Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

@hugovkhugovkhugovk approved these changes

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

awaiting mergedocsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cfbolz@pablogsal@hugovk@picnixz