gh-123290: fix some leaks in curses module#123291
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
picnixz added skip news awaiting review extension-modules MemberAuthor
picnixz commented Aug 28, 2024
(Requesting a review from the curses expert; since you're also the RM, you can take your time) |
This was referenced Aug 30, 2024
MemberAuthor
picnixz commented Sep 3, 2024
Closing in favor of #123630. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still leaks when importing the module. I think it's because of the structure it is being constructed and the fact that there are global objects a bit everywhere. I decided not to change the way the module is initialized but I at least wanted to have something where error checks branches do not leak resources.
curseserror-branches #123290