GH-73991: Add pathlib.Path.copy_into() and move_into()#123314
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These two methods accept an *existing* directory path, onto which we join the source path's base name to form the final target path. A possible alternative implementation is to check for directories in `copy()` and `move()` and adjust the target path, which is done in several `shutil` functions. This behaviour is helpful in a shell context, but less so in a stored program that explicitly specifies destinations. For example, a user that calls `Path('foo.py').copy('bar.py')` might not imagine that `bar.py/foo.py` would be created, but under the alternative implementation this will happen if `bar.py` is an existing directory.
pfmoore approved these changes Aug 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two methods accept an existing directory path, onto which we join the source path's base name to form the final target path.
A possible alternative implementation is to check for directories in
copy()andmove()and adjust the target path, which is done in severalshutilfunctions. This behaviour is helpful in a shell context, but less so in a stored program that explicitly specifies destinations. For example, a user that callsPath('foo.py').copy('bar.py')might not imagine thatbar.py/foo.pywould be created, but under the alternative implementation this will happen ifbar.pyis an existing directory.📚 Documentation preview 📚: https://cpython-previews--123314.org.readthedocs.build/