Skip to content

gh-121404: compiler_visit_* --> codegen_visit_*#123382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 5 commits into from
Aug 27, 2024
Merged

gh-121404: compiler_visit_* --> codegen_visit_* #123382

iritkatriel merged 5 commits into from
Aug 27, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Aug 27, 2024•
edited
Loading

@bedevere-appbedevere-appbot mentioned this pull request Aug 27, 2024
Closed
markshannon
markshannon reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a refleak (I think)

@iritkatriel
use VISIT macro
fef1cda
@iritkatriel
split codegen_pattern_mapping_key out of codegen_pattern_mapping to s…
e6e2201
…implify error checking. Used VISIT macro instead of codegen_visit_expr
markshannon
markshannon approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iritkatrieliritkatriel enabled auto-merge (squash) August 27, 2024 11:32
@iritkatrieliritkatriel merged commit da43026 into python:mainAug 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iritkatriel@markshannon