Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Sep 2, 2024

Use _Py_IsImmortalLoose() in bytesobject.c, typeobject.c and ceval.c.

(cherry picked from commit f1a0d96)

Use _Py_IsImmortalLoose() in bytesobject.c, typeobject.c and ceval.c. (cherry picked from commit f1a0d96)
@vstinner
Copy link
MemberAuthor

@encukou: Would you mind to review this backport to 3.13?

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (probably) doesn't cover all the problematic uses of _Py_IsImmortal, but it's a step in the right direction.

@vstinner
Copy link
MemberAuthor

This (probably) doesn't cover all the problematic uses of _Py_IsImmortal, but it's a step in the right direction.

If tomorrow, more issues will be open about this problem, I would suggest considering to change _Py_IsImmortal() to behave as _Py_IsImmortalLoose(). But for now, I prefer smaller changes by using _Py_IsImmortalLoose() instead.

@vstinnervstinner merged commit 10735bf into python:3.13Sep 2, 2024
@vstinnervstinner deleted the bytes_immortal_loose13 branch September 2, 2024 13:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@encukou