Skip to content

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented Sep 8, 2024

@bedevere-appbedevere-appbot added awaiting review tests Tests in the Lib/test dir labels Sep 8, 2024
@skirpichev

This comment was marked as resolved.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eclips4Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 10, 2024
@vstinnervstinner merged commit d2b9b6f into python:mainSep 11, 2024
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@bedevere-app
Copy link

GH-123938 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Sep 11, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@bedevere-app
Copy link

GH-123939 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Sep 11, 2024
@vstinner
Copy link
Member

Merged, thanks @skirpichev.

@skirpichevskirpichev deleted the test-round-szero-123811 branch September 11, 2024 09:29
vstinner added a commit that referenced this pull request Sep 11, 2024
#123939) gh-123811: test that round() can return signed zero (GH-123829) (cherry picked from commit d2b9b6f) Co-authored-by: Sergey B Kirpichev <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
@serhiy-storchaka
Copy link
Member

Is this tested for Decimal?

Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
#123938) gh-123811: test that round() can return signed zero (GH-123829) (cherry picked from commit d2b9b6f) Co-authored-by: Sergey B Kirpichev <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skirpichev@vstinner@serhiy-storchaka@Eclips4@picnixz