gh-123748: Disable HACL SIMD256 on universal builds.#123927
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native HACL implementation added in #119316 compiles fine on single architecture x86_64 and ARM64 macOS builds, but failed when compiled on universal2 builds. This is because the autoconf detection is based on the existence of the
-mavx2compiler flag; this flag is legal in universal builds (because the x86_64 compilation path supports the flag), but this then requires symbols that aren't available on ARM64 builds. A standalone ARM64 build disables this feature.This PR modifies the autoconf check so that if
-mavx2support is detected and the build is universal2, the autoconf feature isn't enabled.