gh-123935: Fix typo in _get_slots in dataclasses.py#123941
Merged
+22 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz added needs backport to 3.12 
MemberAuthor
sobolevn commented Sep 11, 2024
Done! 👍 |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2024
…GH-123941) (cherry picked from commit ac918cc) Co-authored-by: sobolevn <mail@sobolevn.me>
GH-123991 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2024
…GH-123941) (cherry picked from commit ac918cc) Co-authored-by: sobolevn <mail@sobolevn.me>
GH-123992 is a backport of this pull request to the 3.12 branch. |
MemberAuthor
sobolevn commented Sep 12, 2024
Thank you! 🎉 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #118099
Local tests to better understand the problem / test. With this change:
Without this change:
But, since there's no public api to set
__dict__slot similar toweakref_slot, I had to use__dict__as a field name. This is very ugly, I fully understand that. If prefered, I can remove the test completely.__dictoffset__#123935