Skip to content

gh-123290: fix reference leaks in the error-branches of _cursesmodule.c#123953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 6 commits into from
Sep 11, 2024
Merged

gh-123290: fix reference leaks in the error-branches of _cursesmodule.c#123953

vstinner merged 6 commits into from
Sep 11, 2024

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Sep 11, 2024•
edited by bedevere-app bot
Loading

Hello again. Following Victor's suggestion and a private discussion on Discord, I split the PR once again to only focus on ref-leaks in error branches.

@picnixz
Fix reference leaks in the error-branches.
dd00a73
@picnixz
Cosmetic cleanup:
8769dae
- Remove some macros. - Make some macros local instead. - Do not use `error` label in `init()` function to prepare it for its conversion to `exec()`.
@picnixz
Use an internal exec() function to populate the module dictionary.
9f0bc2b
@picnixz
fixup diff
ca0391d
@bedevere-appbedevere-appbot mentioned this pull request Sep 11, 2024
Closed
vstinner
vstinner reviewed Sep 11, 2024
View reviewed changes
vstinner
vstinner reviewed Sep 11, 2024
View reviewed changes
vstinner
vstinner approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner enabled auto-merge (squash) September 11, 2024 15:21
@vstinnervstinner merged commit 2938c3d into python:mainSep 11, 2024
@picnixzpicnixz deleted the curses/fix-refleaks-123290 branch September 11, 2024 15:52
@picnixzpicnixz mentioned this pull request Sep 13, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner